It doesn't look overly "conventional" with the neckline being taken up by the button placement, but it works. It was a quick one afternoon project. I machine-stitched my button holes (it's underwear that no one is going to see!) and used modern plastic buttons from the very large stash from the men's dress shirts that we repurpose. I decided against sleeves (I have extant examples both with and without sleeves)...and just finished the edges with bias tape. I was going to put a little lace on it, but couldn't find any to suit my fancy in the stash, so I didn't.
In all, I like the way it turned out.